Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed metamask integration with forks feature #4023

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed metamask integration with forks feature #4023

wants to merge 1 commit into from

Conversation

piotrwitek
Copy link
Contributor

@piotrwitek piotrwitek commented Sep 16, 2024 •
edited
Loading

I got such error in the console using fork set only for mainnet, this fixed it.

Changes 👷‍♀️

fixed metamask integration with forks feature

How to test 🧪

  • use forks

Summary by CodeRabbit

  • New Features

    • Introduced a new property, blockExplorerUrls, to enhance network configuration for wallet interactions, paving the way for future improvements.

  • Bug Fixes

    • No bug fixes were included in this release.

  • Documentation

    • No updates to documentation were made in this release.

  • Refactor

    • No refactoring changes were made in this release.

  • Style

    • No style changes were made in this release.

  • Tests

    • No new tests were added in this release.

  • Chores

    • No additional chores were performed in this release.

  • Revert

    • No changes were reverted in this release.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024 •
edited
Loading

Walkthrough

The pull request introduces a modification to the addCustomForkToTheWallet function in the injected-wallet-interactions.ts file. A new property, blockExplorerUrls, is added to the network configuration object, initialized to null. This change enhances the data structure without altering the existing logic or control flow of the function.

Changes

File Path Change Summary
features/web3OnBoard/injected-wallet-interactions.ts Added blockExplorerUrls: null in the object returned by addCustomForkToTheWallet(network: NetworkConfig)

Poem

In the code where rabbits play,
A new field hops in today.
Block explorers wait in line,
For URLs that soon will shine.
With each change, we leap and bound,
In the world of code, joy is found! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0ba03be and 09634c8.

Files selected for processing (1)
  • features/web3OnBoard/injected-wallet-interactions.ts (1 hunks)

features/web3OnBoard/injected-wallet-interactions.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piotrwitek